Skip to content

bpo-38693: Prefer f-strings in importlib.resources (importlib_resources 5.0.6).#26387

Merged
miss-islington merged 1 commit into
mainfrom
bpo-38693/importlib-resources-fstrings
May 26, 2021
Merged

bpo-38693: Prefer f-strings in importlib.resources (importlib_resources 5.0.6).#26387
miss-islington merged 1 commit into
mainfrom
bpo-38693/importlib-resources-fstrings

Conversation

@jaraco

@jaraco jaraco commented May 26, 2021

Copy link
Copy Markdown
Member

https://bugs.python.org/issue38693

Automerge-Triggered-By: GH:jaraco

@jaraco

jaraco commented May 26, 2021

Copy link
Copy Markdown
Member Author

bpo link is wrong

@jaraco jaraco force-pushed the bpo-38693/importlib-resources-fstrings branch from 9989c18 to 17012d9 Compare May 26, 2021 19:53
@jaraco jaraco changed the title bpo-33693: Prefer f-strings in importlib.resources (importlib_resources 5.0.6). bpo-38693: Prefer f-strings in importlib.resources (importlib_resources 5.0.6). May 26, 2021
@jaraco jaraco requested a review from gpshead May 26, 2021 20:00

@ericvsmith ericvsmith left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@miss-islington

Copy link
Copy Markdown
Contributor

@jaraco: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit f6fbdb9 into main May 26, 2021
@miss-islington miss-islington deleted the bpo-38693/importlib-resources-fstrings branch May 26, 2021 20:16
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @jaraco for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 26, 2021
…es 5.0.6). (pythonGH-26387)

Automerge-Triggered-By: GH:jaraco
(cherry picked from commit f6fbdb9)

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
@bedevere-bot

Copy link
Copy Markdown

GH-26389 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label May 26, 2021
jaraco added a commit that referenced this pull request May 26, 2021
…es 5.0.6). (GH-26387) (#26389)

Automerge-Triggered-By: GH:jaraco
(cherry picked from commit f6fbdb9)

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants